SUNRPC: Change return value type of .pc_decode
Returning an undecorated integer is an age-old trope, but it's not clear (even to previous experts in this code) that the only valid return values are 1 and 0. These functions do not return a negative errno, rpc_stat value, or a positive length. Document there are only two valid return values by having .pc_decode return only true or false. Signed-off-by:Chuck Lever <chuck.lever@oracle.com> Signed-off-by:
J. Bruce Fields <bfields@redhat.com>
Showing
- fs/lockd/xdr.c 48 additions, 48 deletionsfs/lockd/xdr.c
- fs/lockd/xdr4.c 49 additions, 48 deletionsfs/lockd/xdr4.c
- fs/nfsd/nfs2acl.c 15 additions, 15 deletionsfs/nfsd/nfs2acl.c
- fs/nfsd/nfs3acl.c 11 additions, 11 deletionsfs/nfsd/nfs3acl.c
- fs/nfsd/nfs3xdr.c 59 additions, 59 deletionsfs/nfsd/nfs3xdr.c
- fs/nfsd/nfs4xdr.c 12 additions, 12 deletionsfs/nfsd/nfs4xdr.c
- fs/nfsd/nfsd.h 1 addition, 1 deletionfs/nfsd/nfsd.h
- fs/nfsd/nfssvc.c 3 additions, 3 deletionsfs/nfsd/nfssvc.c
- fs/nfsd/nfsxdr.c 31 additions, 31 deletionsfs/nfsd/nfsxdr.c
- fs/nfsd/xdr.h 10 additions, 10 deletionsfs/nfsd/xdr.h
- fs/nfsd/xdr3.h 15 additions, 15 deletionsfs/nfsd/xdr3.h
- fs/nfsd/xdr4.h 1 addition, 1 deletionfs/nfsd/xdr4.h
- include/linux/lockd/xdr.h 9 additions, 9 deletionsinclude/linux/lockd/xdr.h
- include/linux/lockd/xdr4.h 9 additions, 9 deletionsinclude/linux/lockd/xdr4.h
- include/linux/sunrpc/svc.h 1 addition, 1 deletioninclude/linux/sunrpc/svc.h
Please register or sign in to comment