tcp: switch rtt estimations to usec resolution
Upcoming congestion controls for TCP require usec resolution for RTT estimations. Millisecond resolution is simply not enough these days. FQ/pacing in DC environments also require this change for finer control and removal of bimodal behavior due to the current hack in tcp_update_pacing_rate() for 'small rtt' TCP_CONG_RTT_STAMP is no longer needed. As Julian Anastasov pointed out, we need to keep user compatibility : tcp_metrics used to export RTT and RTTVAR in msec resolution, so we added RTT_US and RTTVAR_US. An iproute2 patch is needed to use the new attributes if provided by the kernel. In this example ss command displays a srtt of 32 usecs (10Gbit link) lpk51:~# ./ss -i dst lpk52 Netid State Recv-Q Send-Q Local Address:Port Peer Address:Port tcp ESTAB 0 1 10.246.11.51:42959 10.246.11.52:64614 cubic wscale:6,6 rto:201 rtt:0.032/0.001 ato:40 mss:1448 cwnd:10 send 3620.0Mbps pacing_rate 7240.0Mbps unacked:1 rcv_rtt:993 rcv_space:29559 Updated iproute2 ip command displays : lpk51:~# ./ip tcp_metrics | grep 10.246.11.52 10.246.11.52 age 561.914sec cwnd 10 rtt 274us rttvar 213us source 10.246.11.51 Old binary displays : lpk51:~# ip tcp_metrics | grep 10.246.11.52 10.246.11.52 age 561.914sec cwnd 10 rtt 250us rttvar 125us source 10.246.11.51 With help from Julian Anastasov, Stephen Hemminger and Yuchung Cheng Signed-off-by:Eric Dumazet <edumazet@google.com> Acked-by:
Neal Cardwell <ncardwell@google.com> Cc: Stephen Hemminger <stephen@networkplumber.org> Cc: Yuchung Cheng <ycheng@google.com> Cc: Larry Brakmo <brakmo@google.com> Cc: Julian Anastasov <ja@ssi.bg> Signed-off-by:
David S. Miller <davem@davemloft.net>
Showing
- include/linux/tcp.h 4 additions, 4 deletionsinclude/linux/tcp.h
- include/net/tcp.h 7 additions, 3 deletionsinclude/net/tcp.h
- include/uapi/linux/tcp_metrics.h 5 additions, 2 deletionsinclude/uapi/linux/tcp_metrics.h
- net/ipv4/tcp.c 4 additions, 4 deletionsnet/ipv4/tcp.c
- net/ipv4/tcp_cubic.c 0 additions, 4 deletionsnet/ipv4/tcp_cubic.c
- net/ipv4/tcp_hybla.c 7 additions, 5 deletionsnet/ipv4/tcp_hybla.c
- net/ipv4/tcp_illinois.c 0 additions, 1 deletionnet/ipv4/tcp_illinois.c
- net/ipv4/tcp_input.c 88 additions, 95 deletionsnet/ipv4/tcp_input.c
- net/ipv4/tcp_ipv4.c 1 addition, 1 deletionnet/ipv4/tcp_ipv4.c
- net/ipv4/tcp_lp.c 0 additions, 1 deletionnet/ipv4/tcp_lp.c
- net/ipv4/tcp_metrics.c 49 additions, 34 deletionsnet/ipv4/tcp_metrics.c
- net/ipv4/tcp_minisocks.c 2 additions, 2 deletionsnet/ipv4/tcp_minisocks.c
- net/ipv4/tcp_output.c 6 additions, 9 deletionsnet/ipv4/tcp_output.c
- net/ipv4/tcp_probe.c 1 addition, 1 deletionnet/ipv4/tcp_probe.c
- net/ipv4/tcp_vegas.c 0 additions, 1 deletionnet/ipv4/tcp_vegas.c
- net/ipv4/tcp_veno.c 0 additions, 1 deletionnet/ipv4/tcp_veno.c
- net/ipv4/tcp_yeah.c 0 additions, 1 deletionnet/ipv4/tcp_yeah.c
Please register or sign in to comment