Forum | Documentation | Website | Blog

Skip to content
Snippets Groups Projects
Commit 64b22030 authored by Jan Rekorajski's avatar Jan Rekorajski Committed by Greg Kroah-Hartman
Browse files

XFS bug in log recover with quota (bugzilla id 855)

commit 8ec6dba2 upstream.

Hi,
I was hit by a bug in linux 2.6.31 when XFS is not able to recover the
log after a crash if fs was mounted with quotas. Gory details in XFS
bugzilla: http://oss.sgi.com/bugzilla/show_bug.cgi?id=855

.

It looks like wrong struct is used in buffer length check, and the following
patch should fix the problem.

xfs_dqblk_t has a size of 104+32 bytes, while xfs_disk_dquot_t is 104 bytes
long, and this is exactly what I see in system logs - "XFS: dquot too small
(104) in xlog_recover_do_dquot_trans."

Signed-off-by: default avatarJan Rekorajski <baggins@sith.mimuw.edu.pl>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAlex Elder <aelder@sgi.com>
Cc: Simon Kirby <sim@hostway.ca>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent 1bb36e83
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment