exec: Convert security_bprm_set_creds into security_bprm_repopulate_creds
Rename bprm->cap_elevated to bprm->active_secureexec and initialize it in prepare_binprm instead of in cap_bprm_set_creds. Initializing bprm->active_secureexec in prepare_binprm allows multiple implementations of security_bprm_repopulate_creds to play nicely with each other. Rename security_bprm_set_creds to security_bprm_reopulate_creds to emphasize that this path recomputes part of bprm->cred. This recomputation avoids the time of check vs time of use problems that are inherent in unix #! interpreters. In short two renames and a move in the location of initializing bprm->active_secureexec. Link: https://lkml.kernel.org/r/87o8qkzrxp.fsf_-_@x220.int.ebiederm.org Acked-by:Linus Torvalds <torvalds@linux-foundation.org> Reviewed-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
"Eric W. Biederman" <ebiederm@xmission.com>
Showing
- fs/exec.c 4 additions, 4 deletionsfs/exec.c
- include/linux/binfmts.h 2 additions, 2 deletionsinclude/linux/binfmts.h
- include/linux/lsm_hook_defs.h 1 addition, 1 deletioninclude/linux/lsm_hook_defs.h
- include/linux/lsm_hooks.h 2 additions, 2 deletionsinclude/linux/lsm_hooks.h
- include/linux/security.h 4 additions, 4 deletionsinclude/linux/security.h
- security/commoncap.c 4 additions, 5 deletionssecurity/commoncap.c
- security/security.c 2 additions, 2 deletionssecurity/security.c
Please register or sign in to comment